Skip to content

switch kindest/node version to fix linux #3643

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Sep 5, 2025
Merged

switch kindest/node version to fix linux #3643

merged 1 commit into from
Sep 5, 2025

Conversation

grokspawn
Copy link
Contributor

Description of the change:
adopt the same strategy as operator-controller in ensuring that kindest/node versions are always using the latest available version for the kind version, so long as it never changes MINOR version from our supported k8s version.

Motivation for the change:
operator-framework/operator-controller#2047 did the same thing for operator-controller, but we failed to make the same change here

Architectural changes:

Testing remarks:

Reviewer Checklist

  • Implementation matches the proposed design, or proposal is updated to match implementation
  • Sufficient unit test coverage
  • Sufficient end-to-end test coverage
  • Bug fixes are accompanied by regression test(s)
  • e2e tests and flake fixes are accompanied evidence of flake testing, e.g. executing the test 100(0) times
  • tech debt/todo is accompanied by issue link(s) in comments in the surrounding code
  • Tests are comprehensible, e.g. Ginkgo DSL is being used appropriately
  • Docs updated or added to /doc
  • Commit messages sensible and descriptive
  • Tests marked as [FLAKE] are truly flaky and have an issue
  • Code is properly formatted

@grokspawn
Copy link
Contributor Author

I'd normally switch the shebang version to /usr/bin/env bash instead, but in this case I wanted to keep parity between the two repos (and the script isn't relying on any higher-version bash-isms anyway).

@trgeiger
Copy link
Contributor

trgeiger commented Sep 4, 2025

lgtm

@grokspawn
Copy link
Contributor Author

verify requirement should disappear once openshift/release#68905 merges.

@grokspawn
Copy link
Contributor Author

/approve

@openshift-ci openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Sep 4, 2025
@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Sep 5, 2025
@openshift-ci OpenShift CI
Copy link

openshift-ci bot commented Sep 5, 2025

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: grokspawn, perdasilva

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:
  • OWNERS [grokspawn,perdasilva]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-merge-bot openshift-merge-bot bot merged commit 96b249c into operator-framework:master Sep 5, 2025
14 checks passed
@grokspawn grokspawn deleted the kind-image-bug branch September 5, 2025 13:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@perdasilva perdasilva perdasilva approved these changes

@ankitathomas ankitathomas Awaiting requested review from ankitathomas

@kevinrizza kevinrizza Awaiting requested review from kevinrizza

Assignees

@perdasilva perdasilva

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@grokspawn @trgeiger @perdasilva